Skip to content

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin: deepin_loongarch_desktop_defconfig: disable irqsoff_tracer#825

Merged
Avenger-285714 merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2025-05-30-irqsoff-tracer
May 30, 2025
Merged

[Deepin-Kernel-SIG] [linux 6.6-y] [Deepin] deepin: deepin_loongarch_desktop_defconfig: disable irqsoff_tracer#825
Avenger-285714 merged 1 commit into
deepin-community:linux-6.6.yfrom
opsiff:linux-6.6.y-2025-05-30-irqsoff-tracer

Conversation

@opsiff
Copy link
Copy Markdown
Member

@opsiff opsiff commented May 30, 2025

deepin inclusion
category: performance

Disable the debug config shows that +20% improvement in old version UnixBench syscall test from 4914 to 5898(3A6000). And improve the whole score by 8%.

Summary by Sourcery

Enhancements:

  • Disable the irqsoff tracer debug configuration in the LoongArch desktop defconfig to improve syscall and overall performance by disabling IRQ-off tracing

deepin inclusion
category: performance

Disable the debug config shows that +20% improvement
in old version UnixBench syscall test from 4914 to 5898(3A6000).
And improve the whole score by 8%.

Signed-off-by: Wentao Guan <guanwentao@uniontech.com>
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented May 30, 2025

Reviewer's Guide

Disables the irqsoff_tracer debug option in the Deepin LoongArch desktop defconfig to boost syscall and overall UnixBench performance by removing the related configuration flag.

File-Level Changes

Change Details Files
Disabled irqsoff_tracer debug tracer in the LoongArch deepin desktop defconfig
  • Removed the CONFIG_IRQSOFF_TRACER=y entry
arch/loongarch/configs/deepin_loongarch_desktop_defconfig

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@Avenger-285714
Copy link
Copy Markdown
Member

/approve

@Avenger-285714
Copy link
Copy Markdown
Member

/lgtm

@deepin-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Avenger-285714

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Avenger-285714
Copy link
Copy Markdown
Member

/ok-to-test

@deepin-ci-robot
Copy link
Copy Markdown

deepin pr auto review

代码审查意见如下:

  1. 移除不必要的配置项

    • 移除了 CONFIG_IRQSOFF_TRACER 配置项。如果这个配置项不再需要,那么移除是合理的。但是,如果这个配置项是必要的,那么移除可能会导致功能缺失或调试困难。
  2. 配置项的顺序

    • 配置项的顺序没有变化,但是建议保持一定的逻辑顺序,比如将所有与调试和性能分析相关的配置项放在一起,以提高代码的可读性。
  3. 代码注释

    • 如果移除 CONFIG_IRQSOFF_TRACER 是有意为之,建议在代码中添加相应的注释说明为什么移除这个配置项,以便其他开发者理解这一变更的背景。
  4. 代码风格一致性

    • 确保整个配置文件中的代码风格保持一致,比如缩进和空格的使用。

总体来说,这次代码变更看起来是合理的,只要确保移除 CONFIG_IRQSOFF_TRACER 是经过充分考虑的,并且这一变更不会影响系统的正常运行。

@Avenger-285714 Avenger-285714 merged commit 971b635 into deepin-community:linux-6.6.y May 30, 2025
5 of 7 checks passed
Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @opsiff - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants